chore: use rebased go-tss library #2514
Conversation
gartnera
added
no-changelog
WalkthroughThe updates primarily involve changing import paths for various TSS-related packages to new locations in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
gartnera
force-pushed
the
use-rebased-go-tss
branch
from
b6f14b1 to
ec0a9f9
Compare
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (14)
- cmd/zetaclientd/gen_pre_params.go (1 hunks)
- cmd/zetaclientd/keygen_tss.go (1 hunks)
- cmd/zetaclientd/main.go (1 hunks)
- cmd/zetaclientd/p2p_diagnostics.go (4 hunks)
- cmd/zetaclientd/start.go (3 hunks)
- go.mod (7 hunks)
- x/observer/client/cli/tx_vote_blame.go (1 hunks)
- x/observer/types/utils.go (1 hunks)
- x/observer/types/utils_test.go (1 hunks)
- zetaclient/chains/interfaces/interfaces.go (1 hunks)
- zetaclient/testutils/mocks/zetacore_client.go (1 hunks)
- zetaclient/tss/tss_signer.go (2 hunks)
- zetaclient/zetacore/client_vote.go (1 hunks)
- zetaclient/zetacore/tx_test.go (1 hunks)
Additional context used
Path-based instructions (13)
x/observer/types/utils.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.cmd/zetaclientd/gen_pre_params.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.cmd/zetaclientd/main.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/observer/types/utils_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/observer/client/cli/tx_vote_blame.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/zetacore/client_vote.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.cmd/zetaclientd/p2p_diagnostics.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/interfaces/interfaces.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.cmd/zetaclientd/keygen_tss.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.cmd/zetaclientd/start.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/zetacore/tx_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/testutils/mocks/zetacore_client.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/tss/tss_signer.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Additional comments not posted (25)
x/observer/types/utils.go (2)
3-3: Update import path due to repository migration.The import path has been updated to reflect the new repository location.
Line range hint
5-14:
LGTM!The
ConvertNodesfunction is correct and efficient.cmd/zetaclientd/gen_pre_params.go (2)
10-10: Update import path due to repository migration.The import path has been updated to reflect the new repository location.
Line range hint
12-34:
LGTM!The command
GenPrePramsCmdis correctly defined and handles file operations and error handling appropriately.cmd/zetaclientd/main.go (2)
11-11: Update import path due to repository migration.The import path has been updated to reflect the new repository location.
Line range hint
13-23:
LGTM!The main function is correctly defined and handles command execution and error handling appropriately.
x/observer/types/utils_test.go (2)
7-7: Update import path due to repository migration.The import path has been updated to reflect the new repository location.
Line range hint
10-43:
LGTM!The test cases for
ConvertNodesare comprehensive and correctly defined.x/observer/client/cli/tx_vote_blame.go (1)
15-15: LGTM! Import path update is correct.The import path change aligns with the PR objective to use the rebased go-tss library.
zetaclient/zetacore/client_vote.go (1)
7-7: LGTM! Import path update is correct.The import path change aligns with the PR objective to use the rebased go-tss library.
cmd/zetaclientd/p2p_diagnostics.go (3)
30-30: Change in parameter type forpeersis correct.The change from
p2p.AddrListto[]maddr.Multiaddraligns with the updated import paths and types.
62-62: Change in variable type forexternalAddris correct.The change from
Multiaddrtomaddr.Multiaddraligns with the updated import paths and types.
74-76: Change in parameter type forAddrsFactoryfunction is correct.The change from
[]Multiaddrto[]maddr.Multiaddraligns with the updated import paths and types.zetaclient/chains/interfaces/interfaces.go (1)
19-19: LGTM! Import path update is correct.The import path change aligns with the PR objective to use the rebased go-tss library.
cmd/zetaclientd/keygen_tss.go (1)
12-14: LGTM!The import paths have been correctly updated to reflect the repository migration.
cmd/zetaclientd/start.go (2)
Line range hint
1-1:
LGTM!The import paths for
coreandp2ppackages have been correctly removed.
360-367: LGTM!The function signature of
initPeershas been correctly updated to return a slice ofmaddr.Multiaddr.go.mod (4)
22-22: LGTM!The dependency
gitlab.com/thorchain/tss/go-tsshas been correctly added.
22-22: LGTM!The dependency
github.com/zeta-chain/go-tsshas been correctly removed.
68-68: LGTM!The dependency
gitlab.com/thorchain/tss/tss-libhas been correctly added.
354-354: LGTM!The replacement for
github.com/binance-chain/tss-libwithgitlab.com/thorchain/tss/tss-lib v0.1.5has been correctly added.zetaclient/zetacore/tx_test.go (1)
23-23: LGTM!The import path for the
blamepackage has been correctly updated to reflect the repository migration.zetaclient/testutils/mocks/zetacore_client.go (1)
6-6: Update import path for blame package.The import path for the
blamepackage has been updated togitlab.com/thorchain/tss/go-tss/blame. Ensure this path is correct and consistent with the new repository structure.zetaclient/tss/tss_signer.go (2)
23-23: Add new import for go-multiaddr.The
go-multiaddrpackage has been added as a new import. Ensure this is necessary and correctly used in the code.
26-29: Update import paths for TSS-related packages.The import paths for
common,keysign,tss, andkeygenpackages have been updated to the new repository locations in thegitlab.com/thorchainnamespace. Ensure these paths are correct and consistent with the new repository structure.
Description
Use rebased go-tss library which has all upstream fixes and most of our updates. This branch is passing all unit tests in CI unlike master. If/when this PR is approved/merged I will force push this new branch to master.
Related to:
How Has This Been Tested?
Summary by CodeRabbit